rollup / plugins

🍣 The one-stop shop for official Rollup plugins
MIT License
3.62k stars 581 forks source link

Typescript plugin transformers API design is incompatible with angular compiler #1667

Closed Haringat closed 1 week ago

Haringat commented 8 months ago

Expected Behavior / Situation

I would like to use the NgTscPlugin from @angular/compiler-cli to create transformers for @rollup/plugin-typescript. NgTscPlugin#createTransformers seems to have exactly the return type that the rollup plugin can use.

Actual Behavior / Situation

In order to call createTransformers, I have to have called setupCompilation, which needs a program, which is only available inside the factory method of a program transformer. So I would need to be inside a transformer to create the transformers.

Modification Proposal

If possible, it would be nice to have the transformers configuration option be a callback that is provided with a program (and maybe even a compilerhost?) and returns the transformers object.

shellscape commented 8 months ago

Thanks for the issue. This isn't likely to see any traction unless there's a contribution from the community. Mostly because, well Angular, but also bc this is an Angular specific problem whereas we don't have the issue with the majority of frameworks (otherwise we'd have a flood of issues about it)

Mr-Jami commented 2 months ago

Did this get fixed? I also need it for an angular project.

shellscape commented 2 months ago

@Mr-Jami please brush up on how to read issues and associated pull requests. the linked PR has not been merged.