rollup / plugins

🍣 The one-stop shop for official Rollup plugins
MIT License
3.57k stars 568 forks source link

[@rollup/plugin-commonjs]: dynamically requiring a built-in node.js module in an esm script will always throw #1676

Closed perrin4869 closed 4 months ago

perrin4869 commented 4 months ago

Expected Behavior

Doing a dynamic require of a bulit-in node module should succeed, regardless of the settings of dynamicRequireTargets, ignoreDynamicRequire.

Actual Behavior

The dynamic require will throw in all possible configurations of these settings.

Additional Information

I encountered this issue while bundling the latest version of nock (13.5.1). It does a dynamic require of http and https, but this require will always throw if the target is an esm module run in node.js. If ignoreDynamicRequire is false, it'll throw with Could not dynamically require \"http\". Please configure the dynamicRequireTargets or/and ignoreDynamicRequires option of @rollup/plugin-commonjs appropriately for this require call to work.. If ignoreDynamicRequire is true, it will throw due to require not being defined inside the esm module. It should be relatively easy to fix it so this behavior is supported, but probably best done by someone familiar with the codebase 😅