Closed younggglcy closed 5 months ago
@rollup/plugin-esm-shim
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1649
See the repro #1649 given, the shims were inserted into wrong position because the object
{ keyword: ' import', dn: '', };
matches the ESMStaticImportRegex regex.
ESMStaticImportRegex
This PR fixes it by disallowing \n in the specifier group in the regex.
\n
looking good
ping politely here. can anyone help merge this pr
Rollup Plugin Name:
@rollup/plugin-esm-shim
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1649
Description
See the repro #1649 given, the shims were inserted into wrong position because the object
matches the
ESMStaticImportRegex
regex.This PR fixes it by disallowing
\n
in the specifier group in the regex.