chore(node-resolve): remove is-builtin-module

43081j commented 3 weeks ago

Node has shipped builtinModules for some time now, so we no longer need a third party package to do this.

Once the engines constraint is bumped in the package.json, we can also move to using the built-in isBuiltin function (available since 16.x).

Rollup Plugin Name: `node-resolve`

This PR contains:

[ ] bugfix
[ ] feature
[x] refactor
[ ] documentation
[ ] other

Are tests included?

[ ] yes (bugfixes and features will not be merged without tests)
[x] no (existing tests should cover it)

Breaking Changes?

[ ] yes (breaking changes will not be merged unless absolutely necessary)
[x] no

43081j commented 3 weeks ago

FYI the engine constraint in here actually specifies 14 or something. Which is why I have used the built in modules list (available in 14), but not isBuiltin (available in 16)

Just to be clear

If we can bump the engine constraint to 16, we could use the built in function

43081j commented 2 weeks ago

any chance we can get this merged? 👀

would be a good to pull it into a few dependents

rollup / plugins