`node-resolve` with `browser` under `mainFields` breaks polyfills with its `empty.js`

[5310]

• Rollup Plugin Name: node-resolve
• Rollup Plugin Version: 8.0.1
• Rollup Version: 2.13.1
• Operating System (or Browser): Ubuntu 18.04
• Node Version: 14.3.0

How Do We Reproduce?

A reproduction with the breaking config as well as a working variant has been uploaded here: https://github.com/5310/issue_rollup_plugins_node-resolve-w-browser

Expected Behavior

Upon running npx rollup -c ./rollup.config.broken.js Rollup should produce a browser bundle for my test-case CJS module that depends on some polyfilled Node builtins.

Actual Behavior

The build process fails with: [!] Error: 'Buffer' is not exported by node-resolve:empty.js, imported by node_modules/node-forge/lib/baseN.js

See also: The readme in the reproduction repo, and https://www.pika.dev/npm/snowpack/discuss/275

/cc @FredKSchott @quasor

[FredKSchott]

I can reproduce this with the xlsx package as well

[duke79]

I'm facing the same issue.

snowpack failed to load node_modules/xlsx/dist/cpexcel.js 
'Buffer' is not exported by node-resolve:empty.js, imported by node_modules/xlsx/dist/cpexcel.js

[duke79]

@shellscape Why is my comment marked off-topic? In case my problem is not a related one, please let me know.

[stale[bot]]

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ

[wangchongchong1007]

@duke79 Is there a solution to this problem?

Rollup: Missing Export 'Buffer' is not exported by node-resolve:empty.js, imported by ./node_modules/xlsx/dist/cpexcel.js

[Avnerus]

@duke79, @wangchongchong1007 I was able to work around this by adding a plugin hook which adds syntheticNamedExports: true to node-resolve:empty.js. This is the hook:

const addSyntheticNamedExportsToSkippedNodeImports = () => ({
  load: (importee) => {
    if (importee === '\u0000node-resolve:empty.js') {
      return {code: 'export default {};', syntheticNamedExports: true};
    } else {
      return null;
    }
  }
});

It needs to be in the plugin chain before nodeResolve.

   ...
    addSyntheticNamedExportsToSkippedNodeImports(),
    nodeResolve({
          browser: true
    }),
    ...

I will work on making a separate issue about this.