search

rollup / rollup-plugin-babel

This package has moved and is now available at @rollup/plugin-babel / https://github.com/rollup/plugins/tree/master/packages/babel
MIT License
702 stars 87 forks source link

Force babel helpers #325

Closed skeggse closed 4 years ago

skeggse commented 5 years ago

Supercedes #292. @Andarist feel free to just force-update the ref on your PR to f644b9a instead.

Fixes #309.

Andarist commented 5 years ago

It would be great to also implement this - https://github.com/rollup/rollup-plugin-babel/issues/303 . Probably better to do that as a separate PR (after landing this one). Would you be also interested in helping with that?

I've also just reapplied~ comments from the old PR, when you resolve those then I'm going to do last round of review.

Andarist commented 5 years ago

@skeggse will you be able to work this in the future (no pressure) or should I put it on my todo list?

skeggse commented 5 years ago

Apologies - we're in the process of dropping rollup @mixmaxhq due to finding that webpack provides a 30x improvement in incremental builds times. I don't currently have bandwidth to work on this - sorry!

Andarist commented 5 years ago

Sure, no problem - I'll take it over from here. Perf problems might be worth reporting to Rollup itself though, I bet the team would love the feedback on that.

Andarist commented 4 years ago

Closing this in favor of https://github.com/rollup/rollup-plugin-babel/pull/339 (a fork of this PR)