search

rollup / rollup-plugin-image

This module has moved and is now available at @rollup/plugin-image / https://github.com/rollup/plugins/blob/master/packages/image
41 stars 13 forks source link

Remove AST #7

Closed timdp closed 4 years ago

timdp commented 6 years ago

I ran into #2 and it reminded me of a similar issue I had with one of my own plugins. For whatever reason, adding an AST seems to confuse Rollup. This patch makes the plugin only return code rather than an object, because a source map is useless in this case anyway.

regrettably commented 5 years ago

Any traction on this?

antony commented 5 years ago

@Rich-Harris This is a potential blocker for Sapper webpack -> rollup conversion which seems to impact quite a few people. Are we doing something wrong or is this a genuine issue that needs to be resolved?

shellscape commented 4 years ago

I've applied this change to the module as it was being migrated to https://github.com/rollup/plugins. It's now published under @rollup/plugin-image. Please reference the CHANGELOG when updating.

Thanks for your prior work on this!