search

rollup / rollup-plugin-node-resolve

This module has moved and is now available at @rollup/plugin-node-resolve / https://github.com/rollup/plugins/blob/master/packages/node-resolve
MIT License
468 stars 96 forks source link

Add initial support for syntax proposal #211

Closed kristoferbaxter closed 4 years ago

kristoferbaxter commented 5 years ago

Adds support for resolving syntax: esmodules when specifying the option.

kristoferbaxter commented 5 years ago

This PR will be ready to review once the following are complete:

@developit

kristoferbaxter commented 5 years ago

@lukastaegert – This PR is failing on Travis since it's testing with Node 6 (which has excited LTS support). https://nodejs.org/en/about/releases/

Do you intend to keep support Node 6? If so I can refactor the test using an async function back to a function:Promise without await keywords.

lukastaegert commented 5 years ago

Yes, I think we will still stick with Node 6 for some time. Not too long ago, I even got complaints because I accidentally broke Node 4 compatibility in one plugin. Maybe next year we can think about Node 8...

kristoferbaxter commented 5 years ago

No problem. I'll move this method back and restore the Buble pipeline.

Thanks for the info!

kristoferbaxter commented 5 years ago

I've resolved this issue, the PR is ready for review.

lukastaegert commented 5 years ago

What about the blog post? Would be sad to support something that nobody knows about.

kristoferbaxter commented 5 years ago

Definately, we're all a bit slow right now in recovery from Google IO. We'll get the post ready for next week.

shellscape commented 4 years ago

@kristoferbaxter I'd hate to close this as abandoned after all the work that was put into it. It looks like there are now quite a few conflicts since your last commit. Would you be interested in updating this PR? We're getting ready to move this plugin to https://github.com/rollup/plugins and are tying up loose ends.

kristoferbaxter commented 4 years ago

Let's go ahead and close it. There doesn't appear to be consensus on this direction.

shellscape commented 4 years ago

Thank you for following up.