search

rollup / rollup-plugin-node-resolve

This module has moved and is now available at @rollup/plugin-node-resolve / https://github.com/rollup/plugins/blob/master/packages/node-resolve
MIT License
469 stars 96 forks source link

replace buble with babel, update deps #216

Closed dima-takoy-zz closed 5 years ago

dima-takoy-zz commented 5 years ago

This PR is a part of changesets described here https://github.com/rollup/rollup-plugin-node-resolve/pull/213#issuecomment-489497514

dima-takoy-zz commented 5 years ago

Should I create another PR where I update dependencies?

Can I update those inside this PR?

lukastaegert commented 5 years ago

Can I update those inside this PR?

Definitely!

dima-takoy-zz commented 5 years ago

After those changes, I think we can rewrite sources to async-await syntax. It will be compiled to promises by babel then we just change target version to 8 ;)

I already have a branch with refactored this package to async-await syntax. Should I send a PR?

lukastaegert commented 5 years ago

Sounds good! I assume it will also work for the tests via babel-register?

dima-takoy-zz commented 5 years ago

Sounds good! I assume it will also work for the tests via babel-register?

I think yes. It already works with it.

current mocha opts(with this PR):

--require @babel/register
dima-takoy-zz commented 5 years ago

SHould I add refactored to async-await version to this PR?

lukastaegert commented 5 years ago

SHould I add refactored to async-await version to this PR?

Sure, sounds good, considering you already seem to have done the work. Just avoid utils/promisify for the Node 6 compatibility.

dima-takoy-zz commented 5 years ago

I prefer to merge this PR as is. Then I add PR with refactored to async-await syntax.