search

rollup / rollup-plugin-node-resolve

This module has moved and is now available at @rollup/plugin-node-resolve / https://github.com/rollup/plugins/blob/master/packages/node-resolve
MIT License
469 stars 96 forks source link

dedupe & yarn workspaces/lerna #238

Closed btakita closed 4 years ago

btakita commented 5 years ago

How Do We Reproduce?

npx degit ctx-core/lerna-template myproject
cd myproject
npx degit ctx-core/sapper-template#rollup-plugin-node-resolve-issues-238 packages/web
yarn
bin/tsc-build.sh
cd packages/web
yarn run dev

Expected Behavior

Npm packages installed using yarn workspaces should be included in build when using dedupe.

Actual Behavior

could not be resolved – treating it as an external dependency warnings

btakita commented 5 years ago

It looks like the importee does not allow yarn workspaces to resolve the location of the package.

https://github.com/rollup/rollup-plugin-node-resolve/blob/master/src/index.js#L224

shellscape commented 4 years ago

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid. We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets transferred to the new repo. :beer: