search

rollup / rollup-starter-lib

Bare-bones example of how to create a library using Rollup
MIT License
961 stars 230 forks source link

Update dev dependencies to the latest versions #51

Closed mikeharder closed 5 years ago

mikeharder commented 5 years ago

Updates all dev dependencies in package.json and package-lock.json to latest.

These packages depend on each other so must be updated either at the same time or in the correct order (rollup, then rollup-plugin-commonjs, then rollup-plugin-node-resolve).

The update to rollup-plugin-commonjs (#47) fails because the version of rollup in package-lock.json is still 1.0.0. Should GreenKeeper be keeping package-lock.json updated, or is it something you do manually?

The update to rollup-plugin-node-resolve (#48) fails with error TypeError: Cannot read property 'rollupVersion' of undefined because it depends on rollup-plugin-commonjs@10.0.0.

mikeharder commented 5 years ago

@eventualbuddha: Do you think this repo should update to the latest dependency versions?

eventualbuddha commented 5 years ago

Yes, I tend to prefer everything be kept as up to date as possible in both package.json and package-lock.json. If you want to update Rollup in this PR as well I’d be happy to merge.

mikeharder commented 5 years ago

@eventualbuddha: I've updated package.json with the latest version of each dev dependency.