rollup / stream

🍣 Stream Rollup build results
MIT License
22 stars 12 forks source link

Fix warning messages #6

Closed ghost closed 4 years ago

ghost commented 4 years ago

This PR contains:

Are tests included?

Breaking Changes?

List any relevant issue numbers:

4

Description

Fixes #4, this time with a unit test.

@petabyteboy please include tests next time you contribute to a rollup project. I was moving too quick today to see that you had checked the box but did not include tests. That's not cool.

It was not obvious to me that this meant automated unit tests, sorry. I thought it would be sufficient to run manual tests and confirm that the problem is fixed.

shellscape commented 4 years ago

It was not obvious to me that this meant automated unit tests, sorry. I thought it would be sufficient to run manual tests and confirm that the problem is fixed.

Thank you for taking the time to open a new PR. I'll update out template to make that more clear, thank you for pointing that out.

kermage commented 4 years ago

Any update here?