search

rom-py / rompy

Relocatable Ocean Modelling in PYthon (rompy) combines templated cookie-cutter model configuration with various xarray extensions to assist in the setup and evaluation of coastal ocean model
https://rom-py.github.io/rompy/
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Object naming inconsistent #27

Open tomdurrant opened 1 year ago

tomdurrant commented 1 year ago

Why is Swan prefixed to SwanDataGrid but not to DataBoundary even though they both look swan specific. This is item 6 from the June workshop

tomdurrant commented 1 year ago

@rafa-guedes @benjaminleighton I propose we do not use model specific naming, but rather use the full path of the import to determine the model.

i.e. from swan import DataGrid or from schism import DataGrid

rafa-guedes commented 1 year ago

I don't have a strong opinion on this, happy either way. On the specific case of DataBoundary, the intention is to move that as a core object and have specific swan ones that will inherit from that and write swan specific file formats.

rafa-guedes commented 1 year ago

Here is an attempt to implement the changes mentioned above: https://github.com/rom-py/rompy/pull/30.