search

rom-py / rompy

Relocatable Ocean Modelling in PYthon (rompy) combines templated cookie-cutter model configuration with various xarray extensions to assist in the setup and evaluation of coastal ocean model
https://rom-py.github.io/rompy/
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

Fix bug in ordering of args when rendering SwanConfigComponents using a DataBoundary #47

Closed benjaminleighton closed 1 year ago

benjaminleighton commented 1 year ago

Changed order of BoundaryInterface get method to match expectation in call in SwanConfigComponents on order of arguments to boundary.render. This aligns the order with DataInterface and ingrid. This fixes a bug in rendering SwanConfigComponents

rafa-guedes commented 1 year ago

@benjaminleighton this one has been fixed with the latest pull request, please try updating your code to the current version in main. It was a bug I introduced when I was working on some upgrades in the components branch, you may have pulled the code before that was fixed!

benjaminleighton commented 1 year ago

Hi @rafa-guedes. I think I'm running against f13235 on main and I'm still seeing this behaviour. I might have something configured wrong in my environment. I've added a new test test_swan_model_boundary in test_swan_model.py that will fail on main to demonstrate the problem.

rafa-guedes commented 1 year ago

@benjaminleighton apologies I misread your first message - I thought you were talking about DataInterface. BoundaryInterface was indeed inconsistent - I haven't implemented some of the changes in the api in that object and I wasn't using it in the tests / notebooks I was doing so it passed unnoticed. I'll merge this now.