rom-py / rompy

Relocatable Ocean Modelling in PYthon (rompy) combines templated cookie-cutter model configuration with various xarray extensions to assist in the setup and evaluation of coastal ocean model
https://rom-py.github.io/rompy/
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Add dependency to bottom friction validator for param.nml #55

Open VHernaman opened 10 months ago

VHernaman commented 10 months ago

You already have an awesome validator for bottom friction in param.nml, but it makes sense to add one more here because the bottom friction approach you use also turns on/off the wave boundary formulation layer (iwbl) and sets the approach

if manning.gr3 used, then nchi=-1 and iwbl=0; if drag.gr3 used, then nchi=0 and iwbl=0; if rough.gr3 is used, then nchi=1 and iwbl=1 (modified Grant-Madsen formulation) or 2 (Soulsby 1997).

(I typically use Grant-Madsen formulation but be good to give the option to have 1 or 2 in case the SCHISM developers bring on new approaches in the future).