search

rom-py / rompy

Relocatable Ocean Modelling in PYthon (rompy) combines templated cookie-cutter model configuration with various xarray extensions to assist in the setup and evaluation of coastal ocean model
https://rom-py.github.io/rompy/
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Wwmbnd #65

Closed tomdurrant closed 4 months ago

hot007 commented 5 months ago

Hi @tomdurrant , I was just looking at the SCHISM notebook (the one we originally sent you, not the rompy demonstration one), I noticed where we do the ocean data interpolation I had a comment about instead using Paul's Haversine approach, wondering whether you got a chance to look at that and is it worth implementing or is the back-sampling 'good enough' that we're happy it's all that's needed? The haversine code I think is that defined in the get wave forcing section of the notebook. I'm not entirely sure if @pbranson was suggesting to use it in the same way for the infilling ocean data, but I've tagged him here in case he wants to chime in :)

hot007 commented 5 months ago

Sorry would you prefer this comment as an issue?

tomdurrant commented 4 months ago

Sorry @hot007 , I am just seeing your comment. Lets create a new issue, I am about to merge this branch. We did discuss is, and in the end, we decided to fill the tails with the last valid point.