search

rom-py / rompy

Relocatable Ocean Modelling in PYthon (rompy) combines templated cookie-cutter model configuration with various xarray extensions to assist in the setup and evaluation of coastal ocean model
https://rom-py.github.io/rompy/
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

non working examples #76

Open geoaanton opened 4 months ago

geoaanton commented 4 months ago

e.g. example file model_swan_example.ipynb is crashing with

ImportError: cannot import name 'SwanModel' from 'rompy.swan'

Hope this makes sense and that I have not made a mistake installing.

geoaanton commented 4 months ago

did not checkout the stable version so I guess things might have been changed since, however the fact remains that the various example files do not seem to work. I will try with stable release 0.1.0 instead

benjaminleighton commented 4 months ago

Hi @geoaanton thanks for pointing that out, we have some old notebooks that need a cleanup or removal. For a working swan example try the notebooks/swan directory https://github.com/rom-py/rompy/blob/main/notebooks/swan/example_procedural.ipynb is a good place to start

geoaanton commented 4 months ago

Thank you very much will give that a try