search

rom-py / rompy

Relocatable Ocean Modelling in PYthon (rompy) combines templated cookie-cutter model configuration with various xarray extensions to assist in the setup and evaluation of coastal ocean model
https://rom-py.github.io/rompy/
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

remove dependency on Np1DArray, Np2DArray #84

Closed tomdurrant closed 3 months ago

tomdurrant commented 4 months ago

These objects allow representations of numpy arrays as pydantic objects. They are the input type for the basegrid object.

We need x and y attributes for that base object for a lot of the logic to work. However, none of the downstream objects require these as inputs. Having them as first class pydantic attributes means that any serialised object includes these as yaml representations of numpy arrays which is really ugly. I suggest we remove these as inputs, and just make them an abstract property instead.

I'll have a play with it and propose something

benjaminleighton commented 3 months ago

Ben to check with SImon on numpy 2 requirements