Changed basegrid object to not take x, y and inputs and instead infer…

rom-py / rompy

Relocatable Ocean Modelling in PYthon (rompy) combines templated cookie-cutter model configuration with various xarray extensions to assist in the setup and evaluation of coastal ocean model

https://rom-py.github.io/rompy/

BSD 3-Clause "New" or "Revised" License

3 stars 9 forks source link

Changed basegrid object to not take x, y and inputs and instead infer… #85

Closed tomdurrant closed 3 months ago

tomdurrant commented 4 months ago

… as properties. Changes in swan and schism to reflect this

closes #84

tomdurrant commented 3 months ago

This removes the depency on NDArray with was causing numpy v2 issues, thus fixing #97

tomdurrant commented 3 months ago

@benjaminleighton @rafa-guedes this should be good to go now

rafa-guedes commented 3 months ago

pydantic_numpy is actually used in a couple of swan components as well. Let me perhaps have a look at this as well @benjaminleighton and @tomdurrant to see if I can find a workaround to stop using those there as well. I'll merge this then.

rafa-guedes commented 3 months ago

pydantic_numpy can be installed alongside numpy<2 if it is pinned to pydantic_numpy<6. I'm going to merge this as is without removing pydantic_numpy requirement as it is used in some swan components and is rather useful to validate some input types.