search

rom-rb / rom-factory

Data generator with support for persistence backends
MIT License
83 stars 42 forks source link

Deprecate Ruby < 2.7 and convert project to kwargs #74

Closed alassek closed 2 years ago

alassek commented 2 years ago

This PR updates the lowest supported Ruby to exclude EOL versions as has already been done in other ROM gems, and removes the compatibility code for the kwarg transition.

Since the distinction between Faker v1 and v2 is essentially a breaking change to support kwargs, I took the initiative to remove Faker v1 from the project as well; v2 supports older rubies than 2.7 so I don't see a compelling reason to keep it.

The fake API is probably the most significant refactor here.

flash-gordon commented 2 years ago

Let's merge it in, I'll fix rubocop offences in main