search

rom-rb / rom-yesql

rom-rb adapter inspired by original Yesql from the Clojure world
http://rom-rb.org
MIT License
32 stars 6 forks source link

Upgrade to rom 5 #15

Closed mrship closed 4 years ago

mrship commented 4 years ago

🔧 Upgrades to Rom v5, modifying the dataset method in the YeSQL relation to correctly define the query methods and to return self per the new requirements for Rom v5. 🔪 Removes the unnecessary definition of query methods in the class initialisation 📝 Defines the schema correctly for classes derived from a YeSQL relation 💚 We have a green test suite, but have not been able to test this directly in a Rom5-based YeSQL project. ⚠️ This does not fix rubocop warnings, as was unsure of the requirements for the project. 📜 No documentation changes have been made either, e.g. to explain the new requirements for a YeSQL relation. 📫 Closes #14

solnic commented 4 years ago

@mrship thank you! I'll update the codebase separately so that we run CI via Github Actions + integrate this project with rom-rb/devtools and fix rubocop offences. Then I'll release a new version.

solnic commented 3 years ago

@mrship sorry it took me so long, but here's finally released rom-yeql 1.0.0 https://github.com/rom-rb/rom-yesql/releases/tag/v1.0.0