Improve error when command is not defined

thiagoa commented 8 years ago

This pull request is part of the following issue: rom-rb/rom#324

I made the following changes:

Removed ROM::Registry tests, which were moved over to the rom-support repo, in the following pull request: https://github.com/rom-rb/rom-support/pull/6
Added tests for the new "default value" feature of ROM::Registry#fetch. The code is in rom-support (PR referenced above), but the tests are in this repository. To make this possible I temporarily pointed the rom-support gem reference to my rom-support fork, but this will get removed once the related pull request is OK.
I'm using the "default value" feature to throw a specialized error in case a command is not found under a relation.

solnic commented 8 years ago

Thanks for this. The specs should be moved to rom-support. Here we could only verify if command-specific registry has correct behavior.

thiagoa commented 8 years ago

@solnic Thanks. I've just updated this pull request with the removal of the registry spec file, and the rom-support pull request was updated with the same spec file which was moved over from here.

solnic commented 8 years ago

Could you rebase on top of master so that we can get a clean merge?

thiagoa commented 8 years ago

@solnic All done

rom-rb / rom

Improve error when command is not defined #342