rom-rb / rom

Data mapping and persistence toolkit for Ruby
https://rom-rb.org
MIT License
2.08k stars 161 forks source link

Deprecate & remove ad-hoc compositions #415

Closed solnic closed 7 years ago

solnic commented 7 years ago

Since early version of rom-repository we supported so called ad-hoc composition of relations, which means in practice that you can compose aggregates without defining associations. This involves inferring FKs and attribute names using naming conventions. This was useful when we didn't have associations, but now it's completely unnecessary. Furthermore this costs us A LOT of additional complexity throughout the code. Now that we have associations, and they are about to be available to all adapters, we can remove ad-hoc composition support and simplify a lot of code.

TODO

solnic commented 7 years ago

k this is done in master, I added deprecation warnings to rom-3 and rom-repository-1.3 so I'll push new releases soon.