search

rom-rb / rom

Data mapping and persistence toolkit for Ruby
https://rom-rb.org
MIT License
2.09k stars 161 forks source link

Auto-generate #with #431

Closed flash-gordon closed 7 years ago

flash-gordon commented 7 years ago

It's a kind of PoC, @solnic do you think it's a good idea to have with by default?

P.S. We cannot have it in dry-initializer because it has an API for renaming option keys

solnic commented 7 years ago

Yes it's a good idea, I already had cases where I defined it yet-another-time but with a bug and things got broken, so it'd be good to have it solved once and for all.

flash-gordon commented 7 years ago

What should I do with Schema#with? It's marked as a public API but don't think anyone is going to miss it

solnic commented 7 years ago

What should I do with Schema#with? It's marked as a public API but don't think anyone is going to miss it

It's fine if it's gone, just make sure it's deprecated in release-3.0 branch

flash-gordon commented 7 years ago

@solnic I meant the doc is gone, the method is still there, now auto-generated 😬

solnic commented 7 years ago

@flash-gordon I believe we're masters of using yard features nobody knows about, so we can still document it :)