rom-rb / rom

Data mapping and persistence toolkit for Ruby
https://rom-rb.org
MIT License
2.09k stars 161 forks source link

Types/coercible json naming change #447

Closed Krule closed 7 years ago

Krule commented 7 years ago

Addressing: https://github.com/rom-rb/rom/pull/446#discussion_r133506000

Rename CoercibleMethods HashJson -> HashJSON, JsonHash -> JSONHash

Refactor attributes to keyword arguments.

PR for 4.X will follow shortly.

@solnic I am also thinking about extending this a bit more by making it possible for JSON serializer to be plugged in. Any thoughts on idea? cc: @flash-gordon

solnic commented 7 years ago

Thanks man :)