search

rom-rb / rom

Data mapping and persistence toolkit for Ruby
https://rom-rb.org
MIT License
2.08k stars 161 forks source link

Remove `#aggregate` method from repo #453

Closed timriley closed 5 years ago

timriley commented 7 years ago

This does nothing more than forward arguments to #combine on the root relation. Keeping this method here makes repos more confusing (users need to understand how aggregate works, and its special connection to the root relation) and also confuses the fact that a repo should be able to work with more than one relation.

timriley commented 7 years ago

@solnic reckon this is worth getting done before 4.0.0?

solnic commented 7 years ago

@timriley not really, feels too late. I'll remove it in rom-repo 3.0 and for now just remove it from docs and deprecate in rom-repo 2.1

flash-gordon commented 7 years ago

@solnic for now, we could add an alias alias_method :combine, :aggregate