Incompatible with dry-initializer 2.6.0

gingerhendrix commented 5 years ago

Describe the bug

Attempting to use Commands fails with a Dry::Types::ContraintError

/home/gareth/.rvm/gems/ruby-2.5.1/gems/dry-types-0.12.2/lib/dry/types/constrained.rb:28:in `block in call': nil violates constraints (type?(Symbol, nil) AND included_in?([:create, :update, :delete], nil) failed) (Dry::Types::ConstraintError)

Forcing the previous version of dry-initializer solves the problem.

see: https://github.com/dry-rb/dry-initializer/blob/master/CHANGELOG.md#260-2018-09-09

To Reproduce

Gemfile:

source "https://rubygems.org"

gem "rom"
gem "rom-sql"
gem "sqlite3"

Output of bundle list:

Gems included by the bundle:
  * bundler (1.16.2)
  * concurrent-ruby (1.0.5)
  * dry-configurable (0.7.0)
  * dry-container (0.6.0)
  * dry-core (0.4.7)
  * dry-equalizer (0.2.1)
  * dry-inflector (0.1.2)
  * dry-initializer (2.6.0)
  * dry-logic (0.4.2)
  * dry-struct (0.4.0)
  * dry-types (0.12.3)
  * ice_nine (0.11.2)
  * inflecto (0.0.2)
  * rom (4.2.1)
  * rom-changeset (1.0.2)
  * rom-core (4.2.1)
  * rom-mapper (1.2.1)
  * rom-repository (2.0.2)
  * rom-sql (2.5.0)
  * sequel (5.12.0)
  * sqlite3 (1.3.13)
  * transproc (1.0.2)

Example script from: https://github.com/rom-rb/rom/blob/master/repository/examples/sql.rb

require 'rom-repository'

conf = ROM::Configuration.new(:sql, 'sqlite::memory')

migration = conf.gateways[:default].migration do
  change do
    create_table(:users) do
      primary_key :id
      column :name, String, null: false
      column :email, String, null: false
    end
  end
end

migration.apply(conf.gateways[:default].connection, :up)

class Users < ROM::Relation[:sql]
  schema(infer: true)

  def by_id(id)
    where(id: id)
  end
end

conf.register_relation(Users)
rom = ROM.container(conf)

class UserRepo < ROM::Repository[:users]
  commands :create, update: :by_id, delete: :by_id

  def [](id)
    users.by_id(id).one!
  end

  def all
    users.to_a
  end
end

user_repo = UserRepo.new(rom)

user = user_repo.create(name: 'Jane', email: 'jane@doe.org')

puts user.inspect

Expected behavior

Should run without exceptions.

Workaround

Adding

gem 'dry-initializer', "2.4.0"

and running bundle update solves the problem.

Your environment

Affects my production application: NO
Ruby version: 2.5.1

solnic commented 5 years ago

hey @nepalez why did this start breaking?

flash-gordon commented 5 years ago

@gingerhendrix thanks for reporting

nepalez commented 5 years ago

@solnic Sorry, but I can do nothing for now because I’m on vacation without any notebook. I could look at it only in a week. It’s sad, but the only proposal from me for now is locking the dependency at 2.5.0