Better Warning module detection in spec_helper.rb

rom-rb / rom

Data mapping and persistence toolkit for Ruby

https://rom-rb.org

MIT License

2.08k stars 161 forks source link

Closed deepj closed 5 years ago

deepj commented 5 years ago

This is based on the following issue in Truffleruby https://github.com/oracle/truffleruby/issues/1470 and a suggestion by @eregon.

It's better to check availability of Warning module if given Ruby interpret has it rather than checking only Ruby version.

The latest Truffleruby 1.0.0-rc9 claims to be compatible with Ruby 2.4. Unfortunately, it doesn't contain Warning module yet.

flash-gordon commented 5 years ago

okay, thanks!

@solnic don't we have Travis configured for running PR builds? 🤔

solnic commented 5 years ago

@flash-gordon it was disabled, I just enabled it