Closed v-kolesnikov closed 5 years ago
This looks good to me, thanks @v-kolesnikov. I'll let @solnic or @flash-gordon have final say before merging in this case, though.
If I could offer any suggestion here, it's that I'd want to put a description for the empty it
example inside the "with nested nodes" spec example, just for consistency :)
@timriley Thank you for the review!
@v-kolesnikov thanks, could you also add a deprecation warning that this method goes away to release-4.2
branch?
@v-kolesnikov thanks, could you also add a deprecation warning that this method goes away to
release-4.2
branch?
👌
Remove
Repository::Root#aggregate
in favor ofRelation#combine
Upgrade example:
ROM 4.x
ROM 5.x