Make Schema#[] raise when attribute name is not unique

rom-rb / rom

Data mapping and persistence toolkit for Ruby

https://rom-rb.org

MIT License

2.07k stars 161 forks source link

Make Schema#[] raise when attribute name is not unique #543

Closed waiting-for-dev closed 4 years ago

waiting-for-dev commented 5 years ago

Fixes #529

waiting-for-dev commented 5 years ago

It is all a matter of taste, but if you prefer I can make hounds happy :smile:

solnic commented 4 years ago

@waiting-for-dev 👋 any chance you could rebase it on top of latest master? I merged all 4 gems into one so now everything is in lib + we made lots of rubocop adjustments.

waiting-for-dev commented 4 years ago

Done @solnic :rocket: