search

rom-rb / rom

Data mapping and persistence toolkit for Ruby
https://rom-rb.org
MIT License
2.08k stars 161 forks source link

Generalize plugin API #545

Closed flash-gordon closed 5 years ago

flash-gordon commented 5 years ago

We should have done it earlier, it's way simpler now.

flash-gordon commented 5 years ago

Oh, actually it's not. Even more, I added name to Plugin, this means this method makes no sense now. I'll remove it now.

solnic commented 5 years ago

@flash-gordon I recommend paying attention to coverage diffs in PRs. I've had situations like that few times and it helps in spotting dead code.