search

rom-rb / rom

Data mapping and persistence toolkit for Ruby
https://rom-rb.org
MIT License
2.07k stars 161 forks source link

Sort files before loading at auto-registration #614

Closed v-kolesnikov closed 3 years ago

v-kolesnikov commented 3 years ago

Dir.glob doesn't guarantee the order of listed files. It is inconvenient and leads random fails on different platforms in different environments: development, CI, production etc.

It is recommended to sort required files listed by Dir.glob:

solnic commented 3 years ago

@v-kolesnikov thanks this makes sense - notice that master is in 6.0.0 mode already. Do you want me to cherry-pick this into the release-5.2 and push rom-core 5.2.4?

v-kolesnikov commented 3 years ago

Do you want me to cherry-pick this into the release-5.2 and push rom-core 5.2.4?

@solnic I would appreciate. Many thanks!

solnic commented 3 years ago

@v-kolesnikov OK I will do it and let you know!