Closed v-kolesnikov closed 3 years ago
Freezing configuration settings in ROM::Support::Configurable is too aggressive https://github.com/rom-rb/rom/blob/d34b4795b7d91598be7ad7be9c0aa9dc82d54771/core/lib/rom/support/configurable.rb#L39
Configuration setting may be an object that has mutations on itself, so we shouldn't freeze that objects. For example: https://github.com/rom-rb/rom-elasticsearch/pull/14
Mutable objects could be able to set as configuration settings.
Describe the bug
Freezing configuration settings in ROM::Support::Configurable is too aggressive https://github.com/rom-rb/rom/blob/d34b4795b7d91598be7ad7be9c0aa9dc82d54771/core/lib/rom/support/configurable.rb#L39
To Reproduce
Configuration setting may be an object that has mutations on itself, so we shouldn't freeze that objects. For example: https://github.com/rom-rb/rom-elasticsearch/pull/14
Expected behavior
Mutable objects could be able to set as configuration settings.