search

rom1504 / clip-retrieval

Easily compute clip embeddings and build a clip retrieval system with them
https://rom1504.github.io/clip-retrieval/
MIT License
2.42k stars 213 forks source link

Update dependencies to torch 2 #310

Open christopher-kuhn opened 1 year ago

christopher-kuhn commented 1 year ago

Can the torch requirement be updated to work with torch 2.0 or higher? Having torch 1.9 or lower as a requirement is an issue when having other projects depending on torch 2.0 or newer

rom1504 commented 1 year ago

Yes, please open a PR and make sure the CI is passing

Also maybe let's enable dependabot

On Tue, Sep 5, 2023, 12:08 Christopher Kuhn @.***> wrote:

Can the torch requirement be updated to work with torch 2.0 or higher? Having torch 1.9 or lower as a requirement is an issue when having other projects depending on torch 2.0 or newer

— Reply to this email directly, view it on GitHub https://github.com/rom1504/clip-retrieval/issues/310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437XJLRTWCHMGN6NGU7TXY32Z3ANCNFSM6AAAAAA4LQ4TVQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

akameswa commented 1 year ago

@christopher-kuhn Please try re-installing your required torch version after clip's. I tested for 2.1 with 11.8, and it worked fine.