search

rom1504 / embedding-reader

Efficiently read embedding in streaming from any filesystem
MIT License
92 stars 19 forks source link

Fix to ValueError raised on Windows when this function is run (https://github.com/criteo/autofaiss/issues/113) #36

Closed Frikallo closed 1 year ago

Frikallo commented 1 year ago

path.index in your code would always result in a ValueError on windows machines because the paths have reversed backslashes. With this fix its compatible with any path no matter which way the backslashes are facing.

rom1504 commented 1 year ago

Ci failing

Frikallo commented 1 year ago

ubuntu-latest did not have python 3.6 available, migrated to a compatible version

omarirfa commented 1 year ago

was having the same error using autofaiss 2.15.5 while running build_index on windows, this pull request immensely helped in solving the issue! Thanks!

rom1504 commented 1 year ago

thanks