Would there be a way to allow for more recent pyarrow versions?

rom1504 / embedding-reader

Efficiently read embedding in streaming from any filesystem

MIT License

92 stars 19 forks source link

Would there be a way to allow for more recent pyarrow versions? #39

Closed gietema closed 7 months ago

gietema commented 1 year ago

Hi, would there be a way to allow more recent pyarrow versions? The current pyarrow>=6.0.1,<8 requirements means we're stuck with a version from 2017, and makes it difficult to install libraries that require more recent versions. Is there a specific reason this library uses pyarrow>=6.0.1,<8.

I'm happy to contribute to any implementation changes if needed.

victor-paltz commented 1 year ago

Hello! Yes it is possible, this PR will loosen the constraints: https://github.com/rom1504/embedding-reader/pull/40 I don't see any specific reason why it was pined to <8 max, maybe because it was the last available version for python3.6?

rom1504 commented 1 year ago

yes, depending on a single major version range is a good pattern if packages are following semver. That way users get new minor and patch versions of deps that may improve things ; but they don't get major versions that may break the package.

rom1504 commented 7 months ago

done