search

rom1504 / embedding-reader

Efficiently read embedding in streaming from any filesystem
MIT License
94 stars 19 forks source link

Fix some edges cases and clean some codes #5

Closed hitchhicker closed 2 years ago

hitchhicker commented 2 years ago

The first commit includes only typo fix and code clean. The second commit fixes two bugs in piece_builder.py

  1. The condition when we skip first few files
  2. Raise an error when header_i is out of index.
rom1504 commented 2 years ago

Thanks, looks good! There's just make black lint to run

rom1504 commented 2 years ago

I'm also adding you to the repo, in case it's needed. However let's keep collaborating with PRs

hitchhicker commented 2 years ago

Thanks ! I just pushed a new commit with the fix of lint.