rom1504 / img2dataset

Easily turn large sets of image urls to an image dataset. Can download, resize and package 100M urls in 20h on one machine.
MIT License
3.71k stars 338 forks source link

Fix README regarding lossless webp #288

Closed jonasricker closed 1 year ago

jonasricker commented 1 year ago

In the README it says

webp at quality 100 is lossless

However, I noticed that with --encode_quality 100, images are smaller than expected. According to the OpenCV Docs, lossless compression is only used if IMWRITE_WEBP_QUALITY is above 100. I verified that using --encode_quality 101 generates images with larger file size.

The README should probably be updated to make users aware of this subtle difference.

rom1504 commented 1 year ago

interesting!

could you PR that please ?