Question: Am I right in thinking this module is redundant if you have a custom domain?

romainbessugesmeusy / netlify-plugin-auth0-patch-urls

A Netlify Build plugin that makes Auth0 works with deploy previews

MIT License

7 stars 3 forks source link

Question: Am I right in thinking this module is redundant if you have a custom domain? #19

Closed bristoljon closed 3 years ago

bristoljon commented 3 years ago

Just sanity checking. I installed this plugin and saw that it successfully added the deploy preview urls to allowed origins in auth0 but not the allowed callback urls..

Anyway then I saw the note in the readme about wildcard subdomains being supported but was a bit confused as, it seems to me, if you have a custom domain you would just add *.yourdomain.com to all the domain fields in auth0 and wouldn't need this plugin at all? Is that right?

Thanks in advance

bristoljon commented 3 years ago

Actually I've answered my own question now and just seen this:

https://github.com/romainbessugesmeusy/netlify-plugin-auth0-patch-urls/issues/6

Seems I also misread auth0's docs and thought partial wildcard matching so there is no need for custom domain but this plugin is needed to set the allowed web origins which has to be an absolute url..

Thanks for a great plugin