Allowing deploy from prime url

romainbessugesmeusy / netlify-plugin-auth0-patch-urls

A Netlify Build plugin that makes Auth0 works with deploy previews

MIT License

7 stars 3 forks source link

Allowing deploy from prime url #3

Closed tnovau closed 4 years ago

tnovau commented 4 years ago

Allowing this urls too. When using github is needed to use deploy previews link that netlify provides to you.

DEPLOY_PRIME_URL: This URL represents the primary URL for an individual deploy, or a group of them, like branch deploys and Deploy Previews; for example, https://feature-branch--petsof.netlify.app or https://deploy-preview-1--petsof.netlify.app

Docs

romainbessugesmeusy commented 4 years ago

Hey, why did you close it?

tnovau commented 4 years ago

Just need a few fixes for duplicated urls, will reopen today

tnovau commented 4 years ago

Done :heavy_check_mark:

Please review if it is ok now :+1:

romainbessugesmeusy commented 4 years ago

Hmm I noticed I used my GATBSY_AUTH0_CLIENTID env variable and think it's too specific. I'm gonna rename it AUTH0_CLIENT_ID.

tnovau commented 4 years ago

Good idea, I'm using react is weird to have that name

romainbessugesmeusy commented 4 years ago

1.1.0 is published (minor instead of patch because of ENV variable renaming)