search

romainbrette / holypipette

Holy Pipette
GNU General Public License v3.0
4 stars 0 forks source link

Refactoring calibration #16

Closed romainbrette closed 3 years ago

romainbrette commented 7 years ago

Currently, calibration is in devices/calibratedunit. However, the organization might be more logical with calibration not in devices, especially as it requires a camera and microscope. Instead, we could have a calibratedunit, but in a separate folder. Perhaps there would be no direct access to go/position?

romainbrette commented 7 years ago

Also, I have split calibrate into with_stage and without_stage for debugging. But there is a lot of redundancy which would be eliminated.

romainbrette commented 6 years ago

I suggest moving all calibration procedures to a Calibrator object, in a Manipulation package. Then the rest of CalibratedUnit would be moved into ManipulatorUnit.

One question to answer: how about safe_move and similar manipulation methods?

romainbrette commented 6 years ago

Refactoring is partly done: a single calibrate method (with and without stage), which calls a few other methods.