search

romainguy / kotlin-explorer

Desktop tool to quickly explore disassembled Kotlin code.
Apache License 2.0
745 stars 21 forks source link

Remove duplicate Java Toolchain declaration #12

Closed Omico closed 4 months ago

Omico commented 4 months ago

Duplicated with kotlin.jvm.jvmToolchain

Omico commented 4 months ago

See https://github.com/JetBrains/kotlin/blob/8c97cf99698a00084622ec241ec1293cbd6306bf/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/dsl/ToolchainDsl.kt#L41 They should be the same.

I also tested it on my Mac. Everything looks good.

image
Omico commented 4 months ago

Also, if you don't mind, I want to create a PR to exclude more .idea/** files out of VCS. It will be modified every time in my local environment.

Those are unnecessary changes and should be excluded directly.

image