Closed sureshg closed 1 month ago
This might be the reason for https://github.com/romainguy/kotlin-explorer/pull/60#discussion_r1641789635.
Cause the Jebrains runtime setup on CI is blocked by https://github.com/actions/setup-java/issues/399, fallback to using toolchiain like
From your stacktrace, seems Jebrains runtime is not correctly used.
The thing is, compose desktop gradle plugin should honor jvmToolchain
when using jpackage and seems like that's not happening. May be setting javaHome
explicitly from jvmtoolChain
might help.
val defToolchain = extensions.findByType(JavaPluginExtension::class)?.toolchain
val javaToolchainSvc = extensions.findByType(JavaToolchainService::class)
val jbrHome = javaToolchainSvc?.launcherFor(defToolchain)?.metadata?.installationPath?.asFile?.toPath()
compose {
desktop {
application {
javaHome = jbrHome.toString()
}
}
}
I just changed the workflow because it was not generating release DMGs (they were not going through proguard). I haven't tested the output in CI yet but it might fix this issue.
I tried, seems it doesn't work enough.
You can download the dists from the second link above.
Indeed it doesn't work either. But it works when I run the same task locally.
Actually I can open distribution-macos-12 (built on x64 Mac) but distribution-macos-latest (built on arm64 Mac) on my M3 MBP. So weird!
Fixing in #62.
New release github action uses Zulu JDK 17. Is this because of that as jewel requires JBR ?