search

romainguy / kotlin-explorer

Desktop tool to quickly explore disassembled Kotlin code.
Apache License 2.0
745 stars 21 forks source link

Initial support for Windows #7

Closed Omico closed 6 months ago

Omico commented 6 months ago

Just notice we can use org.jetbrains.jewel.window.utils.DesktopPlatform to check what platform users use. Do I need to migrate to that?

Omico commented 6 months ago

Seems org.jetbrains.jewel.window.TitleBar doesn't work correctly on Windows.

image

If we remove it, everything looks fine.

image

Omico commented 6 months ago

Do you want me to add Spotless to do that automatically in another PR?

romainguy commented 6 months ago

Thanks for the suggestion but I'm not fond of auto formatters :)

Thanks for the PR. I'll try to keep Windows in mind but I won't be able to regularly test future changes :/