search

romainpiel / Shimmer-android

(DEPRECATED) An Android TextView with a shimmering effect
2k stars 438 forks source link

library constructor refactor #14

Closed stormzhang closed 9 years ago

stormzhang commented 10 years ago

Refactor ShimmerTextView & ShimmerButton constructor

stormzhang commented 10 years ago

Also remove application attributes, or Manifest merger failed

claust commented 9 years ago

If you have the time, please consider pulling this change, @RomainPiel. I can't seem to avoid the manifest merger error.

romainpiel commented 9 years ago

I don't think this PR is very consistent. I'll apply the second commit separately.

romainpiel commented 9 years ago

@claust check out https://github.com/RomainPiel/Shimmer-android/commit/c11990869b40d8a0b9cf804bf0a7f78bd3b7daf5 I've just uploaded a new version 1.4.0

claust commented 9 years ago

Looks excellent! Thanks! Not available on the Maven repository yet, though?

romainpiel commented 9 years ago

Hmm I think search.maven.org is not synced. But it's definitely up: https://repo1.maven.org/maven2/com/romainpiel/shimmer/library/

claust commented 9 years ago

Yep, it's available and working now. Thanks again!