romainpiel / Shimmer-android

(DEPRECATED) An Android TextView with a shimmering effect
2k stars 438 forks source link

aar file from maven repo contains app icons #23

Open claust opened 9 years ago

claust commented 9 years ago

Even though fixed in the Github code, the 1.4.0 aar file that you download from maven.org still contains the ic_launcher.png files.

To verify, please download the aar file directly, unzip it, and see the ic_launcher.png files inside: http://central.maven.org/maven2/com/romainpiel/shimmer/library/1.4.0/library-1.4.0.aar

Original issue is here: https://github.com/RomainPiel/Shimmer-android/issues/20

fimh commented 8 years ago

Yes, claust was right. I also encountered the same problem in 1.4.0.

Jaymo commented 8 years ago

Easiest way to solve this is by adding tools:replace="android:icon" in the application tag of your manifest

romainpiel commented 8 years ago

Sorry guys I don't have much time to spend on shimmer at the moment. I'll try to spend some time this weekend but I can't promise anything. On 1 Sep 2015 4:42 pm, "James Wahome" notifications@github.com wrote:

Easiest way to solve this is by adding tools:replace="android:icon" in the application tag of your manifest

— Reply to this email directly or view it on GitHub https://github.com/RomainPiel/Shimmer-android/issues/23#issuecomment-136765135 .

vnh1991 commented 8 years ago

@Jaymo

tools:replace="android:icon"

didnt work

casperbang commented 8 years ago

I also ran into this issue, the ic_launcher was removed from the repository itself but a 1.5 Maven release would be beneficial.

romainpiel commented 8 years ago

I don't have much time to spend on Shimmer anymore and it's not a very complex library. Feel free to fork or copy the classes you need into your project.