LinearGradient cache/postInvalidateOnAnimation

romainpiel / Shimmer-android

(DEPRECATED) An Android TextView with a shimmering effect

2k stars 438 forks source link

LinearGradient cache/postInvalidateOnAnimation #3

Closed eveliotc closed 10 years ago

eveliotc commented 10 years ago

Just my ¢2

Most of the time is a bad idea to have new in your draw methods, you'd get a bunch of jank as they are called often specially on animation, and currently there are three of them at LinearGradientFactory#resize method, given that Shaders are immutable, would you consider using a LRU cache?
For 16+ onAnimationEnd consider using postInvalidateOnAnimation instead of postInvalidate

romainpiel commented 10 years ago

Hey

Yes I know the linear gradient thing was going to be an issue at some point. I didn't think of LRU caching, nice one.

Thanks for your comments I'll work on that asap.

romainpiel commented 10 years ago

@eveliotc regarding the LRU cache,

Do you have any recommendations? I'm not sure how to use LruCache for a View itself. I guess it should be external and shared between the different views.
Isn't it a little overkill for this specific problem? Ideally I'd like to reuse the shader but it seems that it can't be done (the logic is on the NDK side)

romainpiel commented 10 years ago

Actually I have a better idea. I can reproduce this effect with a single shader

eveliotc commented 10 years ago

@RomainPiel yeah they are immutable; as I remember you can't translate/zoom the canvas as they are anchored to the window but they do have a local Matrix you could try modifying it (resize and translate)

Pretty sure someone will go crazy and use it in an AdapterView then complain about jank

romainpiel commented 10 years ago

Yep I just got it working with a single linear gradient and playing with the local matrix. I'm cleaning it up and will submit an update later on.

eveliotc commented 10 years ago

:+1:

romainpiel commented 10 years ago

fixed in version 1.1.0