search

romainpiel / Shimmer-android

(DEPRECATED) An Android TextView with a shimmering effect
2k stars 438 forks source link

Memory Leak #30

Open lawloretienne opened 7 years ago

lawloretienne commented 7 years ago

Does the Runnable inside Shimmer.java properly stop? It seems to be causing a memory leak for me.

lawloretienne commented 7 years ago

Here is what the leak looks like : https://gist.github.com/lawloretienne/66ed381b89d543bff6ede5016a0d0ce0

RockyLin commented 7 years ago

Same problem here!

nieldeokar commented 6 years ago

Shimmer shimmer = new Shimmer();

... shimmer.start(tvShimmerText); ...

Cancel shimmer in onDestroy() might help you. 

@Override
    protected void onDestroy() {
        super.onDestroy();
        if (shimmer!=null) {
            shimmer.cancel();
            shimmer = null;
            tvShimmerText = null;
        }
    }