Closed Keanu closed 10 years ago
Thanks for changing branch.
I think we can remove what we have in onAttachedToWindow()
. Your code will call callback.onSetupAnimation()
twice when the view is built.
Hi, I think the onAttachedToWindow()
could be removed.
Whatever the view is GONE or INVISIBLE, it will finally go through onSizeChanged()
when the view is "ready" with VISIBLE, so we can just call callback
in onSizeChanged()
.
yep. I guess it would make sense you add that to the pull request as it comes with your change. I'll merge after that. cheers!
Hi, just updated changes for this pull request, please check that, thanks.
Hi, I added onSizeChanged() in both Button and TextView components to make sure the ineargradient property will be reset properly.
If the Button/TextView changed visibility from GONE to VISIBLE, should call resetLinearGradient() again.