search

romainsacchi / carculator

Prospective environmental and economic life cycle assessment of vehicles made blazing fast.
http://carculator.psi.ch
BSD 3-Clause "New" or "Revised" License
48 stars 14 forks source link

Hydrogen tank #32

Closed A-Sterni closed 9 months ago

A-Sterni commented 9 months ago

If the inventory is exported to an excel file, the hydrogen tank is not considered in the activity "Car, fuel cell electric, ..."

Furthermore, the wrong reference is mentioned for "Fuel tank, compressed hydrogen gas, 700bar, with carbon fiber". The reference is Benitez 2021 (https://doi.org/10.1016/j.jclepro.2020.123277) and not Boureima et al. 2009 Line 96 of https://github.com/romainsacchi/carculator_utils/blob/master/carculator_utils/data/export/references.csv:

A-Sterni commented 9 months ago

I think the hydrogen tank is not considered because the name of the parameter in the file "default_parameters.json" is changed from "fuel tank mass per energy" (in v1.8.4) to "H2 tank mass per energy" (in v1.8.5).

https://github.com/romainsacchi/carculator/blob/master/carculator/data/default_parameters.json https://github.com/romainsacchi/carculator/blob/v.1.8.4/carculator/data/default_parameters.json

romainsacchi commented 9 months ago

Thanks, I will look at it as well as the other issues.